netdev
[Top] [All Lists]

Re: MSEC_TO_JIFFIES is messed up...

To: Valdis.Kletnieks@xxxxxx
Subject: Re: MSEC_TO_JIFFIES is messed up...
From: Davide Libenzi <davidel@xxxxxxxxxxxxxxx>
Date: Wed, 12 May 2004 12:56:04 -0700 (PDT)
Cc: Ingo Molnar <mingo@xxxxxxx>, Jeff Garzik <jgarzik@xxxxxxxxx>, Greg KH <greg@xxxxxxxxx>, Andrew Morton <akpm@xxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Netdev <netdev@xxxxxxxxxxx>
In-reply-to: <200405121947.i4CJlJm5029666@xxxxxxxxxxxxxxxxxxxxxxx>
References: <20040512020700.6f6aa61f.akpm@xxxxxxxx> <20040512181903.GG13421@xxxxxxxxx> <40A26FFA.4030701@xxxxxxxxx> <20040512193349.GA14936@xxxxxxx> <200405121947.i4CJlJm5029666@xxxxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Wed, 12 May 2004 Valdis.Kletnieks@xxxxxx wrote:

> On Wed, 12 May 2004 21:33:49 +0200, Ingo Molnar said:
> > 
> > * Jeff Garzik <jgarzik@xxxxxxxxx> wrote:
> > 
> > > >Woah, that's new.  And wrong.  The code in include/asm-i386/param.h that
> > > >says:
> > > > # define JIFFIES_TO_MSEC(x)     (x)
> > > > # define MSEC_TO_JIFFIES(x)     (x)
> > > >
> > > >Is not correct.  Look at kernel/sched.c for verification of this :)
> > > 
> > > 
> > > Yes, that is _massively_ broken.
> > 
> > why is it wrong?
> 
> If the kernel jiffie is anything other than exactly 1 msec, you're screwed... 

I believe they were talking about include/asm-i386/param.h
                                          ^^^^^^^^


- Davide


<Prev in Thread] Current Thread [Next in Thread>