| To: | Ingo Molnar <mingo@xxxxxxx> |
|---|---|
| Subject: | Re: MSEC_TO_JIFFIES is messed up... |
| From: | Davide Libenzi <davidel@xxxxxxxxxxxxxxx> |
| Date: | Wed, 12 May 2004 12:49:38 -0700 (PDT) |
| Cc: | Jeff Garzik <jgarzik@xxxxxxxxx>, Greg KH <greg@xxxxxxxxx>, Andrew Morton <akpm@xxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Netdev <netdev@xxxxxxxxxxx> |
| In-reply-to: | <20040512193349.GA14936@xxxxxxx> |
| References: | <20040512020700.6f6aa61f.akpm@xxxxxxxx> <20040512181903.GG13421@xxxxxxxxx> <40A26FFA.4030701@xxxxxxxxx> <20040512193349.GA14936@xxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Wed, 12 May 2004, Ingo Molnar wrote: > > * Jeff Garzik <jgarzik@xxxxxxxxx> wrote: > > > >Woah, that's new. And wrong. The code in include/asm-i386/param.h that > > >says: > > > # define JIFFIES_TO_MSEC(x) (x) > > > # define MSEC_TO_JIFFIES(x) (x) > > > > > >Is not correct. Look at kernel/sched.c for verification of this :) > > > > > > Yes, that is _massively_ broken. > > why is it wrong? For HZ == 1000 it's fine, even if it'd better to explicitly make it HZ dependent and let the compiler to discard them. - Davide |
| Previous by Date: | Re: MSEC_TO_JIFFIES is messed up..., Valdis . Kletnieks |
|---|---|
| Next by Date: | Re: MSEC_TO_JIFFIES is messed up..., Davide Libenzi |
| Previous by Thread: | Re: MSEC_TO_JIFFIES is messed up..., Peter Williams |
| Next by Thread: | Re: MSEC_TO_JIFFIES is messed up..., Ingo Molnar |
| Indexes: | [Date] [Thread] [Top] [All Lists] |