netdev
[Top] [All Lists]

Re: [PATCH] bug in ARP override timer near jiffies wrap

To: David Stevens <dlstevens@xxxxxxxxxx>
Subject: Re: [PATCH] bug in ARP override timer near jiffies wrap
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Fri, 7 May 2004 14:55:01 -0700
Cc: netdev@xxxxxxxxxxx, netdev-bounce@xxxxxxxxxxx
In-reply-to: <OFCBE52D62.180AE438-ON88256E8D.0077E81B-88256E8D.00780545@xxxxxxxxxx>
References: <20040507144000.7a57d76a.davem@xxxxxxxxxx> <OFCBE52D62.180AE438-ON88256E8D.0077E81B-88256E8D.00780545@xxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Fri, 7 May 2004 14:51:13 -0700
David Stevens <dlstevens@xxxxxxxxxx> wrote:

> David S. Miller wrote on 05/07/2004 02:40:00 PM:
> 
> > David, do you realize that the existing formula is not only
> > correct, but also covers a greater time space than the
> > time_*() mechanisms do?
> 
> ARG! you're right, of course-- I noticed only that they are
> different and didn't think about it actually be right! :-)

But note that the main point is also that your change is
still correct.

The only reason I know about the time space issue with these
tests is that Alexey mentioned it to me when I was converting
most of the TCP code over to use the time_*() macros.

It is a policy decision whether it is more valuable to be
more consistent or support the larger time space in tests
here and there.

I think it is more important to be consistent, so I'm going
to apply your patch.  And for ARP the larger time space would
never matter anyways :-)

<Prev in Thread] Current Thread [Next in Thread>