netdev
[Top] [All Lists]

Re: [PATCH] bug in ARP override timer near jiffies wrap

To: David Stevens <dlstevens@xxxxxxxxxx>
Subject: Re: [PATCH] bug in ARP override timer near jiffies wrap
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Fri, 7 May 2004 14:40:00 -0700
Cc: netdev@xxxxxxxxxxx
In-reply-to: <OF2E0715FD.603FFEE2-ON88256E8D.006DBE22-88256E8D.006DF160@xxxxxxxxxx>
References: <OF2E0715FD.603FFEE2-ON88256E8D.006DBE22-88256E8D.006DF160@xxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Fri, 7 May 2004 14:01:10 -0600
David Stevens <dlstevens@xxxxxxxxxx> wrote:

> This patch fixes the calculation of "override" in ARP.
 ...
> -               if (jiffies - n->updated >= n->parms->locktime)
> -                       override = 1;
> +               override = time_after(jiffies, n->updated + 
> n->parms->locktime);

David, do you realize that the existing formula is not only
correct, but also covers a greater time space than the
time_*() mechanisms do?

<Prev in Thread] Current Thread [Next in Thread>