netdev
[Top] [All Lists]

Re: Bug#243084: net-tools: netstat do not display some ipv6 listening so

To: "Daniel 'NebuchadnezzaR' Dehennin" <nebuchadnezzar@xxxxxxxxx>, 243084@xxxxxxxxxxxxxxx
Subject: Re: Bug#243084: net-tools: netstat do not display some ipv6 listening sockets
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Sat, 1 May 2004 16:50:11 +1000
Cc: Bernd Eckenfels <be-mail2004@xxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <87fzb9z8zp.fsf@xxxxxxxxxxxxxxxxxx>
References: <E1BCQ8h-0005bb-8s@xxxxxxxxxxxxxxxxxx> <20040411211116.GA32025@xxxxxxxxxxxx> <87smfagpxf.fsf@xxxxxxxxxxxxxxxxxx> <20040412001011.GB3310@xxxxxxxxxxxx> <20040412080013.GA24732@xxxxxxxxxxxxxxxxxxx> <87fzb9z8zp.fsf@xxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.5.1+cvs20040105i
tags 243084 pending
quit

On Mon, Apr 12, 2004 at 02:16:58PM +0200, Daniel 'NebuchadnezzaR' Dehennin 
wrote:
> 
> I made a little piece of code inspired by my patch to mailutils, it's
> dirty code I prefere prevent you ;-)

Thanks for the test case.

Hi Dave:

There is a bug in listening_get_first() which used by /proc/net/tcp*
where it wasn't looping through all the sockets in each hash chain.
This problem doesn't show up unless the first socket in a chain doesn't
match the family that is being looked up.

The following patch fixes this by getting rid of listening_get_first()
altogether.

Cheers,
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Attachment: p
Description: Text document

<Prev in Thread] Current Thread [Next in Thread>
  • Re: Bug#243084: net-tools: netstat do not display some ipv6 listening sockets, Herbert Xu <=