Re: [patch] tg3 ring buffer allocation error handling

[Sven Schuster <schuster.sven@xxxxxx>]

On Wed, Apr 14, 2004 at 01:46:42PM -0500, Matt Mackall told us:
>       if (tp->tg3_flags & TG3_FLAG_JUMBO_ENABLE) {
>               for (i = 0; i < tp->rx_jumbo_pending; i++) {
>                       if (tg3_alloc_rx_skb(tp, RXD_OPAQUE_RING_JUMBO,
> -                                          -1, i) < 0)
> -                             break;
> +                                          -1, i) < 0) {
> +                             printk("tg3_alloc_rx_skb %d failed\n", i);
> +                             return -ENOMEM;

Please correct me if I'm wrong, but shouldn't the buffers from the 
irst allocation (RXD_OPAQUE_RING_STD) be freed (maybe via 
tg3_free_rings??) when we get an error here??


Sven

> +                     }
>               }
>       }
> +
> +     return 0;
>  }
>  

-- 
Linux zion 2.6.5 #1 Sun Apr 4 19:56:55 CEST 2004 i686 athlon i386 GNU/Linux
 22:53:42  up 9 days, 23:37,  2 users,  load average: 0.00, 0.00, 0.00

pgpbPayLFHDbW.pgp
Description: PGP signature