Andrew Morton wrote:
> +#if (PAGE_SIZE != 4096) /* special cache for eth skbs - 5 fit into one
> 8 kB page */
> + CACHE(1620)
1. Shouldn't this be (PAGE_SIZE > 4096)? Yeah, it's not very likely that
we'll ever have to support an arch w/ a page size <4K (I believe the
linux-vax port uses 4K superpages, not the 1K native page size) but it
doesn't hurt to be careful.
2. Maybe also add "&& defined(CONFIG_NET)" to that? You could also argue
for CONFIG_ETHERNET but there's lots of cases where people might want
to use ethernet-sized frames (bridged over ATM, whatever) even if they
don't have any ethernet cards installed.
Doubt there's too many people with 8K page sizes and no networking
support compiled in... but today's high-end is tomorrow's embedded