| To: | chas3@xxxxxxxxxxxxxxxxxxxxx |
|---|---|
| Subject: | Re: [PATCH][ATM]: [nicstar] using dev_alloc_skb() (reported by "Johnston, Jayme" <Jayme.Johnston@xxxxxxxxxxx>) |
| From: | "David S. Miller" <davem@xxxxxxxxxx> |
| Date: | Fri, 9 Apr 2004 16:38:18 -0700 |
| Cc: | chas@xxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <200404071211.i37CB3gK020805@xxxxxxxxxxxxxxxxxxxxxxx> |
| References: | <200404071211.i37CB3gK020805@xxxxxxxxxxxxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Wed, 07 Apr 2004 08:11:04 -0400 "chas williams (contractor)" <chas@xxxxxxxxxxxxxxxx> wrote: > the nicstar driver has typically used alloc_skb() to get its i/o buffers. > since these buffers are likely to be passed to the network stack at some > point it should probably be using dev_alloc_skb(). this patches fixes > a crash during pppoatm operation when an unchecked skb_push() operates on > a buffer returned by the nicstar. > > please apply to 2.6 and 2.4 kernels (and if at all possible could > i get this in the soon to be released 2.4.26 kernel?) Good catch, applied. I'll do my best to get Marcelo to eats this soon, but no promises. :-) |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH][ATM]: get atm_guess_pdu2truesize() right, David S. Miller |
|---|---|
| Next by Date: | Re: [PATCH] tulip, kernel 2.4.26-rc2, 2nd try, Jeff Garzik |
| Previous by Thread: | [PATCH][ATM]: [nicstar] using dev_alloc_skb() (reported by "Johnston, Jayme" <Jayme.Johnston@xxxxxxxxxxx>), chas williams (contractor) |
| Next by Thread: | [janitor] remove concat. with __FUNCTION__ (drivers/net/) (V2), Randy.Dunlap |
| Indexes: | [Date] [Thread] [Top] [All Lists] |