netdev
[Top] [All Lists]

Re: [PATCH] NETDEBUG network triggerable messages in IPv6

To: "YOSHIFUJI Hideaki / _$B5HF#1QL@" <yoshfuji@xxxxxxxxxxxxxx>
Subject: Re: [PATCH] NETDEBUG network triggerable messages in IPv6
From: Andi Kleen <ak@xxxxxxx>
Date: Fri, 9 Apr 2004 19:50:52 +0200
Cc: davem@xxxxxxxxxx, netdev@xxxxxxxxxxx, yoshfuji@xxxxxxxxxxxxxx
In-reply-to: <20040410.024705.97089877.yoshfuji@xxxxxxxxxxxxxx>
References: <20040409182125.348fd6cd.ak@xxxxxxx> <20040410.021840.113165465.yoshfuji@xxxxxxxxxxxxxx> <20040409193123.63e4cdc7.ak@xxxxxxx> <20040410.024705.97089877.yoshfuji@xxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Sat, 10 Apr 2004 02:47:05 +0900 (JST)
YOSHIFUJI Hideaki / _$B5HF#1QL@ <yoshfuji@xxxxxxxxxxxxxx> wrote:


> 
> I'd prefer:
> 
>   if (net_ratelimit())
>     NETDEBUG_PRINTK("overrun destopt\n"..)

This won't optimize away the function call.

> or
> 
>   NETDEBUG_PRINTK_LIMIT("overrun destopt\n"..)
> 
> (or something like this) much more.

... and this will make the lines even longer.

-Andi

<Prev in Thread] Current Thread [Next in Thread>