netdev
[Top] [All Lists]

Re: [PATCH] Avoid gettimeofday when not needed

To: Andi Kleen <ak@xxxxxxx>
Subject: Re: [PATCH] Avoid gettimeofday when not needed
From: Ben Greear <greearb@xxxxxxxxxxxxxxx>
Date: Wed, 31 Mar 2004 10:53:43 -0800
Cc: ak@xxxxxx, vnuorval@xxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20040331195020.4fff9171.ak@xxxxxxx>
Organization: Candela Technologies
References: <200403311201.i2VC13D19579@xxxxxxxxxxx> <Pine.LNX.4.58.0403311552070.19615@xxxxxxxxxxxxxxx> <20040331135449.GB62402@xxxxxxxxxxxxx> <Pine.LNX.4.58.0403311705460.19615@xxxxxxxxxxxxxxx> <20040331151047.GA6033@xxxxxxxxxxxxx> <406B001A.1030901@xxxxxxxxxxxxxxx> <20040331195020.4fff9171.ak@xxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040113
Andi Kleen wrote:

Why not add a 32-bit field to the skb to handle various flag needs
going forward?


That is what ->cb already is

From the comments, it appears each layer can write over these,
and since it's just a block of bytes, it is difficult to understand
what each bit/field is used for.

It still seems to me that a bit-field with well defined
flags is more useful.

Ben

--
Ben Greear <greearb@xxxxxxxxxxxxxxx>
Candela Technologies Inc  http://www.candelatech.com


<Prev in Thread] Current Thread [Next in Thread>