netdev
[Top] [All Lists]

Re: [PATCH] Avoid gettimeofday when not needed

To: Ben Greear <greearb@xxxxxxxxxxxxxxx>
Subject: Re: [PATCH] Avoid gettimeofday when not needed
From: Andi Kleen <ak@xxxxxxx>
Date: Wed, 31 Mar 2004 19:50:20 +0200
Cc: ak@xxxxxx, vnuorval@xxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <406B001A.1030901@xxxxxxxxxxxxxxx>
References: <200403311201.i2VC13D19579@xxxxxxxxxxx> <Pine.LNX.4.58.0403311552070.19615@xxxxxxxxxxxxxxx> <20040331135449.GB62402@xxxxxxxxxxxxx> <Pine.LNX.4.58.0403311705460.19615@xxxxxxxxxxxxxxx> <20040331151047.GA6033@xxxxxxxxxxxxx> <406B001A.1030901@xxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Wed, 31 Mar 2004 09:30:02 -0800
Ben Greear <greearb@xxxxxxxxxxxxxxx> wrote:

> Andi Kleen wrote:
> > On Wed, Mar 31, 2004 at 05:24:47PM +0300, Ville Nuorvala wrote:
> > 
> >>There just doesn't seem to be any general flag field in sk_buff that we
> >>might use at this moment. Should one be added, or should we just hide the
> >>flag inside the cb field using the likes of inet_skb_parm and
> >>inet6_skb_parm?
> > 
> > 
> > There are no free bits indeed. I think ->cb is the best choice then.
> 
> Why not add a 32-bit field to the skb to handle various flag needs
> going forward?

That is what ->cb already is

-Andi

<Prev in Thread] Current Thread [Next in Thread>