netdev
[Top] [All Lists]

Re: [PATCH] Avoid gettimeofday when not needed

To: Ville Nuorvala <vnuorval@xxxxxxxxxx>
Subject: Re: [PATCH] Avoid gettimeofday when not needed
From: Andi Kleen <ak@xxxxxx>
Date: 31 Mar 2004 15:54:49 +0200
Date: Wed, 31 Mar 2004 15:54:49 +0200
Cc: Andi Kleen <ak@xxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <Pine.LNX.4.58.0403311552070.19615@xxxxxxxxxxxxxxx>
References: <200403311201.i2VC13D19579@xxxxxxxxxxx> <Pine.LNX.4.58.0403311552070.19615@xxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.1i
> I suspect this breaks proxy arp/ndisc!
> 
> The arp/ndisc requests are queued up for a random time before being
> processed by the proxy. Check out pneigh_enqueue() in net/core/neighbour.c
> for details. The skb->stamp.tv_sec check was used to separate the locally
> re-fed requests from ones received from the net.

Ok, thanks for clarifying this. I guessed the intention wrong then.

A better way may be to just add a new skb flag for this that is managed
by the arp code? Comments?

-Andi

<Prev in Thread] Current Thread [Next in Thread>