netdev
[Top] [All Lists]

Re: TCP hang in timewait processing

To: Nivedita Singhvi <niv@xxxxxxxxxx>
Subject: Re: TCP hang in timewait processing
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Sun, 28 Mar 2004 01:35:49 -0800
Cc: netdev@xxxxxxxxxxx, bkon@xxxxxxxxxx, jgrimm@xxxxxxxxxx, jgarvey@xxxxxxxxxx
In-reply-to: <40660DF7.9090806@xxxxxxxxxx>
References: <40660DF7.9090806@xxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Sat, 27 Mar 2004 15:27:51 -0800
Nivedita Singhvi <niv@xxxxxxxxxx> wrote:

> Any ideas, pointers would be very much appreciated!

One thing that makes timewait bucket garbage collection interesting
is that the node can be reached from two spots, the death row list
and the TCP hash chains via packet input processing.

So you have to see if scenerios like the following are possible:

1) TW death worker thread choose tw X to be killed, drops tw_death_lock
2) packet input hits tw X, packet is reset which kills the tw
3) packet input thus tries to remove tw X from the death row list
   too and put it

You get the idea.

We had a similar bug recently in the 2.6.x tree but that was due to
a bug in the tw-kill-via-worker-thread code which is not in 2.4.x unless
someone patched it into the 2.4.x tree you are using :-)

<Prev in Thread] Current Thread [Next in Thread>