Re: [BUG] alignment problem in net/core/flow.c:flow_key_compare

[YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx>]

In article <20040318185940.45108d6a.akpm@xxxxxxxx> (at Thu, 18 Mar 2004 
18:59:40 -0800), Andrew Morton <akpm@xxxxxxxx> says:

> Why not simply
> 
> >  +} __attribute__((__aligned__(BITS_PER_LONG/8)));
> 
> ?

Okay;

===== include/net/flow.h 1.10 vs edited =====
--- 1.10/include/net/flow.h     Thu Jan 15 17:18:43 2004
+++ edited/include/net/flow.h   Fri Mar 19 12:04:32 2004
@@ -77,7 +77,7 @@
 #define fl_icmp_type   uli_u.icmpt.type
 #define fl_icmp_code   uli_u.icmpt.code
 #define fl_ipsec_spi   uli_u.spi
-};
+} __attribute__((__aligned__(BITS_PER_LONG/8)));
 
 #define FLOW_DIR_IN    0
 #define FLOW_DIR_OUT   1

-- 
Hideaki YOSHIFUJI @ USAGI Project <yoshfuji@xxxxxxxxxxxxxx>
GPG FP: 9022 65EB 1ECF 3AD1 0BDF  80D8 4807 F894 E062 0EEA