Re: [BUG] alignment problem in net/core/flow.c:flow_key_compare

[Andrew Morton <akpm@xxxxxxxx>]

YOSHIFUJI Hideaki / ____________ <yoshfuji@xxxxxxxxxxxxxx> wrote:
>
>  
>  +#if (BITS_PER_LONG == 64)
>  +#define FLOWI_ALIGN_BYTES 8
>  +#else
>  +#define FLOWI_ALIGN_BYTES 4
>  +#endif
>  +
>   struct flowi {
>       int     oif;
>       int     iif;
>  @@ -77,7 +83,7 @@
>   #define fl_icmp_type        uli_u.icmpt.type
>   #define fl_icmp_code        uli_u.icmpt.code
>   #define fl_ipsec_spi        uli_u.spi
>  -};
>  +} __attribute__((__aligned__(FLOWI_ALIGN_BYTES)));
>  

Why not simply

>  +} __attribute__((__aligned__(BITS_PER_LONG/8)));

?