netdev
[Top] [All Lists]

Re: [8390] Do not use dev->name before register_netdev

To: "Luis R. Rodriguez" <mcgrof@xxxxxxxxxxxxxxxxxxxx>
Subject: Re: [8390] Do not use dev->name before register_netdev
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Sat, 13 Mar 2004 16:42:47 +1100
Cc: Jeff Garzik <jgarzik@xxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <20040313041634.GV32439@xxxxxxxxxxxxxxxxxx>
References: <20040313025859.GA8186@xxxxxxxxxxxxxxxxxxx> <20040313041634.GV32439@xxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.5.1+cvs20040105i
On Fri, Mar 12, 2004 at 11:16:34PM -0500, Luis R. Rodriguez wrote:
> On Sat, Mar 13, 2004 at 01:58:59PM +1100, Herbert Xu wrote:
> > 
> > This patch replaces/removes all uses of dev->name in 8390 drivers.
> > As it is, these drivers will do printks or allocate resources with
> > the name eth%d.
> 
> Why is using dev->name a bad thing? 

It's a bad thing if it's set to eth%d and a number hasn't been
allocated yet.
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

<Prev in Thread] Current Thread [Next in Thread>