| To: | "'Jeff Garzik'" <jgarzik@xxxxxxxxx>, "'Leonid Grossman'" <leonid.grossman@xxxxxxxx> |
|---|---|
| Subject: | RE: Submission #3 for S2io 10GbE driver |
| From: | "ravinandan arakali" <ravinandan.arakali@xxxxxxxx> |
| Date: | Fri, 12 Mar 2004 13:55:37 -0800 |
| Cc: | <netdev@xxxxxxxxxxx>, "'Stephen Hemminger'" <shemminger@xxxxxxxx>, "'Christoph Hellwig'" <hch@xxxxxxxxxxxxx>, <raghavendra.koushik@xxxxxxxx> |
| Importance: | Normal |
| In-reply-to: | <4040F866.9040200@xxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
Hi Jeff, Regarding comment #15, we don't think locking is required, because we just reflect what ever the statistics block is reflecting at the current moment. Thanks, Ravi -----Original Message----- From: Jeff Garzik [mailto:jgarzik@xxxxxxxxx] Sent: Saturday, February 28, 2004 12:22 PM To: Leonid Grossman Cc: netdev@xxxxxxxxxxx; 'Stephen Hemminger'; 'Christoph Hellwig'; 'ravinandan arakali'; raghavendra.koushik@xxxxxxxx Subject: Re: Submission #3 for S2io 10GbE driver Looking a lot better. A few merge issues remain, and some operational ones as well. There are 39 issues in this review, but IMO they are mostly minor issues that don't require much thought or work. Comments: <snipped> 15) does s2io_get_stats need locking? <snipped> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH] make netdevice.h more non-kernel friendly, Stephen Hemminger |
|---|---|
| Next by Date: | [e100 2.6] fix stray skb pointer, Feldman, Scott |
| Previous by Thread: | Re: Submission #3 for S2io 10GbE driver, Ben Greear |
| Next by Thread: | Re: Submission #3 for S2io 10GbE driver, Jeff Garzik |
| Indexes: | [Date] [Thread] [Top] [All Lists] |