[Top] [All Lists]

Re: [PATCH 2.6] Intersil Prism54 wireless driver

To: jt@xxxxxxxxxx
Subject: Re: [PATCH 2.6] Intersil Prism54 wireless driver
From: Jeff Garzik <jgarzik@xxxxxxxxx>
Date: Wed, 10 Mar 2004 12:29:59 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, prism54-devel@xxxxxxxxxxx, "David S. Miller" <davem@xxxxxxxxxx>, netdev@xxxxxxxxxxx, Linux kernel mailing list <linux-kernel@xxxxxxxxxxxxxxx>
In-reply-to: <20040310172114.GA8867@xxxxxxxxxxxxxxxxxx>
References: <20040304023524.GA19453@xxxxxxxxxxxxxxxxxx> <20040310165548.A24693@xxxxxxxxxxxxx> <20040310172114.GA8867@xxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030703
Jean Tourrilhes wrote:
On Wed, Mar 10, 2004 at 04:55:48PM +0000, Christoph Hellwig wrote:
+MODULE_PARM(init_mode, "i");
+                "Set card mode:\n0: Auto\n1: Ad-Hoc\n2: Managed Client 
(Default)\n3: Master / Access Point\n4: Repeater (Not supported yet)\n5: Secondary (Not 
supported yet)\n6: Monitor");

        Please use module_param

        I would even say that this is useless because the driver
support WE, and WE scripts set the mode before the card is up.

module_param() is a type-safe interface roughly identical to MODULE_PARM(). Therefore, if MODULE_PARM() works, module_param() works also.

diff -Naur -X /home/mcgrof/lib/dontdiff 
--- linux-2.6.3/drivers/net/wireless/prism54/isl_wds.c  Thu Jan  1 00:00:00 1970
+++ linux-2.6.3-prism54/drivers/net/wireless/prism54/isl_wds.c  Thu Mar  4 
02:00:01 2004

        WDS doesn't belong into a driver but in higher-level code.

        The big 802.11 reorg can only happen when HostAP is in the

ISTR it needed some cleaning up before it could go in.

Further, in Linux, there is _never_ a requirement that "this driver be included before we can clean up." You can start the re-org any time you wish. Out-of-tree maintainers can follow the re-org, sometimes more easily.


P.S. I still need to look at your netlink thing. Seems like a decent direction.

<Prev in Thread] Current Thread [Next in Thread>