netdev
[Top] [All Lists]

Re: [PATCH] 2.6.3 fix vlan-encapsulated fragmented IP traffic

To: "David S. Miller" <davem@xxxxxxxxxx>
Subject: Re: [PATCH] 2.6.3 fix vlan-encapsulated fragmented IP traffic
From: Bart De Schuymer <bdschuym@xxxxxxxxxx>
Date: Mon, 1 Mar 2004 08:06:29 +0100
Cc: ebtables-devel@xxxxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20040229215421.0ca987e8.davem@xxxxxxxxxx>
References: <200402291914.53578.bdschuym@xxxxxxxxxx> <20040229215421.0ca987e8.davem@xxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: KMail/1.5
On Monday 01 March 2004 06:54, David S. Miller wrote:
> Can you explain the 'mtu' fiddling a little bit?  I think it's correct...
> but you know :)

Between the Ethernet header and the IP header, there will be put a 
vlan-header. This is done in br_dev_queue_push_xmit(), with 
nf_bridge_maybe_copy_header(). By changing the mtu we make sure the IP 
packets arre small enough to allow the vlan header to be added.

> The one case I'm concerned about is when the device does hw acceleration
> of vlan tagging (ie. therefore things are transparent supposedly), is
> the 'mtu' adjustment thing correct in that case?

I don't think that's a problem. We only have this problem when the vlan-tagged 
IP packet enters the bridge as a whole, so the incoming bridge port doesn't 
strip the vlan header. Therefore, the outgoing bridge port shouldn't be 
adding the vlan-header, as it's already supposed to be there.
The difference between the slow_path and the normal path in ip_fragment() is 
that in the normal path we can use the skbuffs of the fragments and these 
already have enough space for the vlan header and the IP fragment size is 
small enough. In the slow_path the skbuffs are constructed and then we need 
these special measures.

> I'm applying this for now, as I can't come up with a better fix either.
> If we find a problem with this change, we'll fix that up.
>
> I'm really concerned, btw, that this is going to propagate to other places
> as well, what if something that gets handled this way gets sent over an
> IPIP tunnel via some route, and then IPIP has to make all of these crazy
> adjustments too?  That's going too far and we'll have to find a better
> way if that is the case.

I'm not sure how IPIP tunnels are implemented, but I'm assuming they strip the 
first IP header like the vlan code strips the vlan header when a vlan-packet 
arrives on a vlan-enabled device. Then there should be no problem with this. 
Even if it's done differently, I don't _think_ it will give a problem.
The problem is caused purely by the fact that the bridge-nf code 
(br_netfilter.c) skb_pulls the packet by 4 bytes if it's an IP packet inside 
a vlan-header, allowing the IP packet to be filtered by iptables, and as far 
as the IP code and iptables is concerned, there is no vlan-header. So we need 
to give the IP code a little help.
Extra code, analogous to the code for vlan, would need to be added in 
nf_bridge_pad() if we were to allow filtering IP packets inside a bridged 
IPIP packet, of course.

cheers,
Bart


<Prev in Thread] Current Thread [Next in Thread>