netdev
[Top] [All Lists]

Re: [PATCH] Fix checksum bug for multicast/broadcast packets on postrout

To: James Morris <jmorris@xxxxxxxxxx>
Subject: Re: [PATCH] Fix checksum bug for multicast/broadcast packets on postrouting hook
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Sat, 28 Feb 2004 21:50:13 -0800
Cc: mika.penttila@xxxxxxxxxxx, laforge@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx, sds@xxxxxxxxxxxxxx
In-reply-to: <Xine.LNX.4.44.0402231713310.21153-100000@xxxxxxxxxxxxxxxxxxxxxxxx>
References: <20040218172441.2eb117a7.davem@xxxxxxxxxx> <Xine.LNX.4.44.0402231713310.21153-100000@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Mon, 23 Feb 2004 17:19:03 -0500 (EST)
James Morris <jmorris@xxxxxxxxxx> wrote:

> This does not seem to be the correct approach.  If you drop packets in 
> the ipsec cases at least, the retransmits just keep feeding packets back 
> in with hardware checksumming set.

Ok, so TCP retransmits do this.

There is a check missing somewhere in the TCP output path then.
Or maybe, it refuses to mess with checksum state after the SKB
has been created, even for further retransmits.

More brainpower needed...

<Prev in Thread] Current Thread [Next in Thread>