| To: | Jeff Garzik <jgarzik@xxxxxxxxx> |
|---|---|
| Subject: | [e1000 netdev-2.6 4/6] delay may be too small |
| From: | "Feldman, Scott" <scott.feldman@xxxxxxxxx> |
| Date: | Sat, 21 Feb 2004 23:25:39 -0800 (PST) |
| Cc: | netdev@xxxxxxxxxxx, "Feldman, Scott" <scott.feldman@xxxxxxxxx> |
| Reply-to: | "Feldman, Scott" <scott.feldman@xxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
* msec_delay macro wouldn't delay at all if x < 10, and
wouldn't delay enough for x = 10. Not a concern for
2.6 (HZ=1000) but is for 2.4 (HZ=100).
----------
diff -Naurp netdev-2.6/drivers/net/e1000/e1000_osdep.h
netdev-2.6/drivers/net/e1000.mod/e1000_osdep.h
--- netdev-2.6/drivers/net/e1000/e1000_osdep.h 2004-02-20 14:07:27.000000000
-0800
+++ netdev-2.6/drivers/net/e1000.mod/e1000_osdep.h 2004-02-20
14:07:56.000000000 -0800
@@ -47,7 +47,7 @@
BUG(); \
} else { \
set_current_state(TASK_UNINTERRUPTIBLE); \
- schedule_timeout((x * HZ)/1000); \
+ schedule_timeout((x * HZ)/1000 + 2); \
} } while(0)
#endif
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [e1000 netdev-2.6 3/6] disable CSA fix for 82547, Feldman, Scott |
|---|---|
| Next by Date: | [e1000 netdev-2.6 5/6] collision retry count too high, Feldman, Scott |
| Previous by Thread: | [e1000 netdev-2.6 3/6] disable CSA fix for 82547, Feldman, Scott |
| Next by Thread: | [e1000 netdev-2.6 5/6] collision retry count too high, Feldman, Scott |
| Indexes: | [Date] [Thread] [Top] [All Lists] |