netdev
[Top] [All Lists]

Re: [PATCH] 2.6.3 pcnet32.c fix link reporting for non-mii devices

To: Don Fry <brazilnut@xxxxxxxxxx>, netdev@xxxxxxxxxxx
Subject: Re: [PATCH] 2.6.3 pcnet32.c fix link reporting for non-mii devices
From: Thomas Munck Steenholdt <tmus@xxxxxxx>
Date: Sat, 21 Feb 2004 22:57:00 +0100
In-reply-to: <200402202232.i1KMWqD07369@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <200402202232.i1KMWqD07369@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040113
Don Fry wrote:
Thomas,

Thanks for the input.  I am the unofficial maintainer, sort of.  I don't
have a card without an mii, so I can't test some of the changes.  Do
you know of a way to determine the link state so I can correctly return
the state?

By the way, are you running 2.4 or 2.6?


Hi again!

Decided to do some research and get this thing implemented right!
I've created a new patch against the 2.6.3-bk3 version of pcnet32.c

What this patch does is that in the event that mii is not supported, link status is read directly from device's lnktst bcr register.

Works without any problem with the virtual nic under vmware. So if all the other non-mii pcnet32 devices have the link status register in the same place, things should be just fine!

Could you please test this and let me know what you think?

Best regards

Thomas

--- drivers/net/pcnet32.c.tmus  2004-02-19 15:24:31.238513096 +0100
+++ drivers/net/pcnet32.c       2004-02-19 15:27:28.265600888 +0100
@@ -1644,7 +1644,9 @@
        case ETHTOOL_GLINK: {
                struct ethtool_value edata = {ETHTOOL_GLINK};
                spin_lock_irq(&lp->lock);
-               edata.data = mii_link_ok(&lp->mii_if);
+               if(lp->mii) edata.data = mii_link_ok(&lp->mii_if);
+                /* read the LNKTST BCR register for link status on non-mii 
capable devices */
+                else edata.data = (lp->a.read_bcr(ioaddr,4) != 0xc0);
                spin_unlock_irq(&lp->lock);
                if (copy_to_user(useraddr, &edata, sizeof(edata)))
                        return -EFAULT;
<Prev in Thread] Current Thread [Next in Thread>