| To: | Jeff Garzik <jgarzik@xxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2.6.1] Allow pcnet_cs to work with shared irq |
| From: | Stephen Hemminger <shemminger@xxxxxxxx> |
| Date: | Thu, 19 Feb 2004 10:30:42 -0800 |
| Cc: | Paul Gortmaker <p_gortmaker@xxxxxxxxx>, netdev@xxxxxxxxxxx |
| In-reply-to: | <403405EE.4020503@xxxxxxxxx> |
| Organization: | Open Source Development Lab |
| References: | <20040120162251.291a0e39.shemminger@xxxxxxxx> <403405EE.4020503@xxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
Here is a rediff'd version of the patch to fix shared irq handling in pcnet_cs
and generic 8390 drivers.
--- linux-2.6/drivers/net/pcmcia/pcnet_cs.c 2004-02-09 10:06:49.000000000
-0800
+++ laptop-2.6/drivers/net/pcmcia/pcnet_cs.c 2004-02-09 16:54:48.000000000
-0800
@@ -1163,10 +1163,11 @@ static irqreturn_t ei_irq_wrapper(int ir
{
struct net_device *dev = dev_id;
pcnet_dev_t *info = PRIV(dev);
- info->stale = 0;
- ei_interrupt(irq, dev_id, regs);
- /* FIXME! Was it really ours? */
- return IRQ_HANDLED;
+ irqreturn_t ret = ei_interrupt(irq, dev_id, regs);
+
+ if (ret == IRQ_HANDLED)
+ info->stale = 0;
+ return ret;
}
static void ei_watchdog(u_long arg)
--- linux-2.6/drivers/net/8390.c 2004-02-09 10:06:49.000000000 -0800
+++ laptop-2.6/drivers/net/8390.c 2004-02-09 16:54:47.000000000 -0800
@@ -513,7 +513,7 @@ irqreturn_t ei_interrupt(int irq, void *
}
}
spin_unlock(&ei_local->page_lock);
- return IRQ_HANDLED;
+ return IRQ_RETVAL(nr_serviced > 0);
}
/**
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 3/3][bonding 2.4] Add VLAN support in ALB mode, Jeff Garzik |
|---|---|
| Next by Date: | Re: [PATCH 3/3][bonding 2.4] Add VLAN support in ALB mode, David S. Miller |
| Previous by Thread: | Re: [PATCH 2.6.1] Allow pcnet_cs to work with shared irq, Jeff Garzik |
| Next by Thread: | Re: [PATCH 2.6.1] Allow pcnet_cs to work with shared irq, Jeff Garzik |
| Indexes: | [Date] [Thread] [Top] [All Lists] |