[Top] [All Lists]

Re: [PATCH] Fix checksum bug for multicast/broadcast packets on postrout

To: James Morris <jmorris@xxxxxxxxxx>
Subject: Re: [PATCH] Fix checksum bug for multicast/broadcast packets on postrouting hook
From: Mika Penttilä <mika.penttila@xxxxxxxxxxx>
Date: Sun, 15 Feb 2004 18:00:52 +0200
Cc: "David S. Miller" <davem@xxxxxxxxxx>, Harald Welte <laforge@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxx, Stephen Smalley <sds@xxxxxxxxxxxxxx>
In-reply-to: <Xine.LNX.4.44.0402150901460.12324-100000@xxxxxxxxxxxxxxxxxxxxxxxx>
References: <Xine.LNX.4.44.0402150901460.12324-100000@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624 Netscape/7.1

James Morris wrote:

On Sun, 15 Feb 2004, Mika Penttilä wrote:

skb_checksum_help() updates skb->ip_summed to CHECKSUM_NONE in the original skb, and this should be seen by the driver. With your change the checksum is calculated twice, once for the looping back packet, and once for the outgoing.

[Looks like my posts are not making it to netdev]

It updates ip_summed in the cloned packet header, but not in the original packet, which gets sent to the driver with an already completed checksum.

See the original post.

- James

ah, sorry, I see your point now. Maybe this copy should be in skb_checksum_help() ?


<Prev in Thread] Current Thread [Next in Thread>