netdev
[Top] [All Lists]

Re: some bluetooth fixes

To: Marcel Holtmann <marcel@xxxxxxxxxxxx>
Subject: Re: some bluetooth fixes
From: Andi Kleen <ak@xxxxxxx>
Date: Sat, 7 Feb 2004 18:24:36 +0100
Cc: Andi Kleen <ak@xxxxxxx>, bluez-devel@xxxxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, viro@xxxxxxxxxxxxxxxxxx
In-reply-to: <1076173068.2670.4.camel@pegasus>
References: <20040206050042.20a2b3b0.ak@xxxxxxx> <1076079512.2806.40.camel@pegasus> <20040207032428.56ffbebc.ak@xxxxxxx> <1076152411.14418.73.camel@pegasus> <20040207125723.391a1fcd.ak@xxxxxxx> <1076173068.2670.4.camel@pegasus>
Sender: netdev-bounce@xxxxxxxxxxx
On Sat, Feb 07, 2004 at 05:57:48PM +0100, Marcel Holtmann wrote:
> I now looked carefully through your patch and changed and added some
> parts to better fit into. I also fixed another RFCOMM refcount bug.
> Please review it, before I send it to Dave.

Doing size checks after the multiply is too late - they could
have already overflowed. You have to check the raw value from the user.

-Andi

<Prev in Thread] Current Thread [Next in Thread>