netdev
[Top] [All Lists]

Re: Deadlock problem with dev->refcnt somewhere in netlink/multicast...

To: David Stevens <dlstevens@xxxxxxxxxx>
Subject: Re: Deadlock problem with dev->refcnt somewhere in netlink/multicast... [PATCH]
From: Willy Tarreau <willy@xxxxxxxxx>
Date: Tue, 3 Feb 2004 07:00:48 +0100
Cc: "David S. Miller" <davem@xxxxxxxxxx>, netdev@xxxxxxxxxxx, jgarzik@xxxxxxxxx, Alexandre.Cassen@xxxxxxxxxx
In-reply-to: <OFDBAB37F5.227951E9-ON88256E2E.0080F5BF@xxxxxxxxxx>
References: <OFDBAB37F5.227951E9-ON88256E2E.0080F5BF@xxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4i
Hi David,

On Mon, Feb 02, 2004 at 04:41:11PM -0700, David Stevens wrote:
> Below is a patch for the reference count problem you ran into.
> 
> The problem is that the IGMP code was using "IFF_UP" to determine
> if a report should be sent or a timer should be started. But it is not
> necessarily cleared during a destroy_dev.
> 
> The IPv4 code was also missing an ip_mc_down() call added in the
> IPv6 code for a similar case by Jan Oravec.

I would never have found this myself !

> The patch is for 2.4.x but also applies to 2.6.x. In-line for
> whitespace-mangled
> viewing and attached for applying.
> 
> Thanks for reporting the problem, Willy, and let me know if you have any
> problems with the patch.

Thanks a lot, I will try ASAP and will report if I still can break it.

Cheers,
Willy


<Prev in Thread] Current Thread [Next in Thread>