|To:||Leonid Grossman <leonid.grossman@xxxxxxxx>|
|Subject:||Re: Submission for S2io 10GbE driver|
|From:||Jeff Garzik <jgarzik@xxxxxxxxx>|
|Date:||Tue, 27 Jan 2004 01:08:32 -0500|
|Cc:||"'Stephen Hemminger'" <shemminger@xxxxxxxx>, "'Andi Kleen'" <ak@xxxxxxx>, netdev@xxxxxxxxxxx, raghavendra.koushik@xxxxxxxx|
|User-agent:||Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030703|
Leonid Grossman wrote:
The loopback test is there as a part of the ethtool's diagnostic option. There are pros and cons of having the test in there I guess, anyone else has an opinion on this? Do other net drivers normally support loopback and other diag tests as a part of the ethtool support, or they provide little/no support for the option and ship a standalone diag program instead?
The ethtool diag stuff is more of a quick sanity test than anything exhaustive.
I definitely want to discourage tons of test code in drivers, as its code that users will almost-never run, it bloats the driver, and can be done with a special diag-only driver or diag program (or a combination of both).
A lot of the 10/100 drivers originated from Donald Becker, who typically creates a userland (i.e. separate) diag program for each driver he writes.
|<Prev in Thread]||Current Thread||[Next in Thread>|
|Previous by Date:||Re: [PATCH] pci_get_slot(), Greg KH|
|Next by Date:||Patch: IPv6/AMD64: bug in net/ipv6/ndisc.c, Jan Kasprzak|
|Previous by Thread:||RE: Submission for S2io 10GbE driver, Leonid Grossman|
|Next by Thread:||RE: Submission for S2io 10GbE driver, Leonid Grossman|
|Indexes:||[Date] [Thread] [Top] [All Lists]|