| To: | Jeff Garzik <jgarzik@xxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] [2.4] forcedeth network driver |
| From: | Vojtech Pavlik <vojtech@xxxxxxx> |
| Date: | Sat, 24 Jan 2004 23:05:45 +0100 |
| Cc: | Manfred Spraul <manfred@xxxxxxxxxxxxxxxx>, Carl-Daniel Hailfinger <c-d.hailfinger.kernel.2004@xxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Netdev <netdev@xxxxxxxxxxx> |
| In-reply-to: | <4012D3C6.1050805@xxxxxxxxx> |
| References: | <4012BF44.9@xxxxxxxxxxxxxxxx> <4012D3C6.1050805@xxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.4.1i |
On Sat, Jan 24, 2004 at 03:21:26PM -0500, Jeff Garzik wrote:
> >>>+static int alloc_rx(struct net_device *dev)
> >>>+{
> >[snip]
> >>>+ return 0;
> >>>+}
> >>
> >>skb_reserve() seems to be missing
> >>
> >Do you have specs that show that all nForce versions support unaligned
> >buffers? skb_reserve is a performance feature, I don't want to add it
> >yet. Testing that it works is on our TODO list.
>
> hmmmm, is nForce ever found on non-x86 boxes? I would think that
> skb_reserve might be -required- for some platforms.
AMD64 and PPC64 as far as I know. But you may consider the first one
still a x86 box.
--
Vojtech Pavlik
SuSE Labs, SuSE CR
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] [2.4] forcedeth network driver, Carl-Daniel Hailfinger |
|---|---|
| Next by Date: | Re: [PATCH] [2.4] forcedeth network driver, Paul Mackerras |
| Previous by Thread: | Re: [PATCH] [2.4] forcedeth network driver, Carl-Daniel Hailfinger |
| Next by Thread: | Re: [PATCH] [2.4] forcedeth network driver, Carl-Daniel Hailfinger |
| Indexes: | [Date] [Thread] [Top] [All Lists] |