netdev
[Top] [All Lists]

Re: [PATCH] more improvement to dev_alloc_name -- strnchr

To: Andi Kleen <ak@xxxxxxx>
Subject: Re: [PATCH] more improvement to dev_alloc_name -- strnchr
From: Alex Pankratov <ap@xxxxxxxxxxxxx>
Date: Mon, 19 Jan 2004 15:27:48 -0800
Cc: Stephen Hemminger <shemminger@xxxxxxxx>, davem@xxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20040119221515.74629ac4.ak@xxxxxxx>
References: <1074302619.40088e9bd44a6@xxxxxxxxxxxxxxx> <20040119113204.5913a8d6.shemminger@xxxxxxxx> <20040119210605.3cea32b0.ak@xxxxxxx> <20040119130744.324f582b.shemminger@xxxxxxxx> <20040119221515.74629ac4.ak@xxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031205 Thunderbird/0.4


Andi Kleen wrote:

Not sure what it has to do with that. The #ifdef __HAVE_ARCH_* stuff is that architectures with crazy enough hackers can add assembly
optimized functions if they want. But it clearly doesn't make any sense
with this function (in fact it doesn't make much sense with any string
function except memset/memcpy) ... [snip]

.. as well as memchr/memrchr/memcmp and strlen. Just nitpicking :)


<Prev in Thread] Current Thread [Next in Thread>