netdev
[Top] [All Lists]

Re: [PATCH 2.6.X] SIOCSIFNAME wilcard suppor & name validation

To: Stephen Hemminger <shemminger@xxxxxxxx>
Subject: Re: [PATCH 2.6.X] SIOCSIFNAME wilcard suppor & name validation
From: Jean Tourrilhes <jt@xxxxxxxxxxxxxxxxxx>
Date: Tue, 13 Jan 2004 14:27:45 -0800
Address: HP Labs, 1U-17, 1501 Page Mill road, Palo Alto, CA 94304, USA.
Cc: Jeff Garzik <jgarzik@xxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxx>, netdev@xxxxxxxxxxx, Linux kernel mailing list <linux-kernel@xxxxxxxxxxxxxxx>
E-mail: jt@xxxxxxxxxx
In-reply-to: <20040113142204.0b41403b.shemminger@xxxxxxxx>
Organisation: HP Labs Palo Alto
References: <20040112234332.GA1785@xxxxxxxxxxxxxxxxxx> <20040113142204.0b41403b.shemminger@xxxxxxxx>
Reply-to: jt@xxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.3.28i
On Tue, Jan 13, 2004 at 02:22:04PM -0800, Stephen Hemminger wrote:
> Here is an enhanced version of the previous patch.
> It adds both the wildcard support that Jean did, and validation of network
> device names.

        Excellent. Your patch looks much cleaner.

> It doesn't check the error return from class_device_rename because
> that will not fail unless object or name are null.

        I was not 100% sure if this would remain true.

        Thanks !

        Jean

<Prev in Thread] Current Thread [Next in Thread>