netdev
[Top] [All Lists]

Re: [EXPERIMENTAL PATCH] 2.4 tulip jumbo frames

To: Jeff Garzik <jgarzik@xxxxxxxxx>
Subject: Re: [EXPERIMENTAL PATCH] 2.4 tulip jumbo frames
From: Rask Ingemann Lambertsen <rask@xxxxxxxxxx>
Date: Sat, 13 Dec 2003 18:29:28 +0100
Cc: netdev@xxxxxxxxxxx
In-reply-to: <3FD5FC36.5090405@xxxxxxxxx>; from jgarzik@xxxxxxxxx on Tue, Dec 09, 2003 at 11:45:42AM -0500
References: <20031209160632.D1345@xxxxxxxxxx> <3FD5FC36.5090405@xxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.2.5.1i
On Tue, Dec 09, 2003 at 11:45:42AM -0500, Jeff Garzik wrote:
> Two questions and a comment...
> 
> Would you split this into two patches?  The first simply adds, and uses, 
> tp->rx_buf_sz.  The second adds PKT_BUF_SZ_MAX and mtu-related changes.

The first patch is attached to this message. I'm not happy with the second
part yet because it is too hackish and I would prefer to have a look at the
tulip documentation first.

> Have you looked at Donald Becker's changes to tulip.c?  He went through 
> most of his drivers and made the changes necessary to support larger 
> MTUs.  IIRC his tulip.c changes (which should be easily translate-able 
> to 2.6.x tulip) were a bit more minimal than your patch, but still 
> served the purpose.

I've just tested Becker's tulip.c v0.97 (7/22/2003) and it fails to receive
packets larger than the standard 1514 bytes. "ping -s 1472" works while
"ping -s 1473" doesn't (when pinging from another box).

-- 
Regards,
Rask Ingemann Lambertsen

Attachment: tulip-rxbufsz.patch
Description: Text document

<Prev in Thread] Current Thread [Next in Thread>