| To: | netdev@xxxxxxxxxxx |
|---|---|
| Subject: | [PATCH 3/4] netrom check error on memcpy_fromiovec |
| From: | Chris Wright <chrisw@xxxxxxxx> |
| Date: | Mon, 8 Dec 2003 20:25:17 -0800 |
| Cc: | davem@xxxxxxxxxx, shemminger@xxxxxxxx |
| In-reply-to: | <20031208202414.D30587@xxxxxxxxxxxxxxxxxx>; from chrisw@xxxxxxxx on Mon, Dec 08, 2003 at 08:24:14PM -0800 |
| References: | <20031208202302.C30587@xxxxxxxxxxxxxxxxxx> <20031208202414.D30587@xxxxxxxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.2.5i |
Check the return value on memcpy_fromiovec().
===== net/netrom/af_netrom.c 1.40 vs edited =====
--- 1.40/net/netrom/af_netrom.c Sun Sep 21 18:17:31 2003
+++ edited/net/netrom/af_netrom.c Fri Dec 5 16:45:14 2003
@@ -1094,7 +1094,12 @@
SOCK_DEBUG(sk, "NET/ROM: Appending user data\n");
/* User data follows immediately after the NET/ROM transport header */
- memcpy_fromiovec(asmptr, msg->msg_iov, len);
+ if (memcpy_fromiovec(asmptr, msg->msg_iov, len)) {
+ kfree_skb(skb);
+ err = -EFAULT;
+ goto out;
+ }
+
SOCK_DEBUG(sk, "NET/ROM: Transmitting buffer\n");
if (sk->sk_state != TCP_ESTABLISHED) {
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH 2/4] irda check error on memcpy_fromiovec, Chris Wright |
|---|---|
| Next by Date: | [PATCH 4/4] rose check error on memcpy_fromiovec, Chris Wright |
| Previous by Thread: | [PATCH 2/4] irda check error on memcpy_fromiovec, Chris Wright |
| Next by Thread: | [PATCH 4/4] rose check error on memcpy_fromiovec, Chris Wright |
| Indexes: | [Date] [Thread] [Top] [All Lists] |