netdev
[Top] [All Lists]

Re: [PATCH] skfddi - convert to new pci model.

To: Stephen Hemminger <shemminger@xxxxxxxx>
Subject: Re: [PATCH] skfddi - convert to new pci model.
From: Alexander Viro <aviro@xxxxxxxxxx>
Date: Fri, 5 Dec 2003 18:27:21 -0500
Cc: Alexander Viro <aviro@xxxxxxxxxx>, Jeff Garzik <jgarzik@xxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <20031205151249.44a067df.shemminger@xxxxxxxx>
References: <20031204163928.0f34d5d1.shemminger@xxxxxxxx> <20031205005915.GD31510@xxxxxxxxxxxxxxxxxxxxxxxx> <20031205151249.44a067df.shemminger@xxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.1i
On Fri, Dec 05, 2003 at 03:12:49PM -0800, Stephen Hemminger wrote:
> Second revision of the cleanup of skfddi driver.
>  * use new pci device bus initialization
>  * allocate network device with alloc_fddidev
>     and use dev->priv
>   * get rid of special module/non module distinctions.
> 
>   * fix error unwinds and return values on initialization
>   * call driver_init directly not via register_netdev
>   * reset internal queue count after purge
>   * get rid of h[iy]sterical comment that is no longer true

Looks sane.

<Prev in Thread] Current Thread [Next in Thread>