[Top] [All Lists]

Re: [PATCH]snmp6 64-bit counter support in proc.c

To: Shirley Ma <mashirle@xxxxxxxxxx>
Subject: Re: [PATCH]snmp6 64-bit counter support in proc.c
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Fri, 5 Dec 2003 12:31:33 -0800
Cc: kuznet@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx, xma@xxxxxxxxxx
In-reply-to: <200312051214.48076.mashirle@xxxxxxxxxx>
References: <200312021240.PAA01536@xxxxxxxxxxxxxxx> <200312051214.48076.mashirle@xxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Fri, 5 Dec 2003 12:14:47 -0800
Shirley Ma <mashirle@xxxxxxxxxx> wrote:

> I add this because there are some 64-bit counters in the new IPv6 MIBs. 
> This patch has been tested agaist linux-2.6.0-test9, and cleanly applied to 
> linux-2.6.0-test11.

"sizeof(unsigned long)" evaluates to 8 on 64-bit systems,
yet you assume it always evaluated to 4 as on 32-bit systems.

Maybe it would be wiser to explicitly use 'u32' and 'u64' for
the types of the snmp counters?

This has always been a sore area.

<Prev in Thread] Current Thread [Next in Thread>