netdev
[Top] [All Lists]

Re: [ROUTE] PMTU only works on half the time

To: Julian Anastasov <ja@xxxxxx>
Subject: Re: [ROUTE] PMTU only works on half the time
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Tue, 2 Dec 2003 16:39:02 -0800
Cc: herbert@xxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <Pine.LNX.4.44.0312030121130.1237-100000@xxxxxxxxxxxx>
References: <20031201155005.1c515793.davem@xxxxxxxxxx> <Pine.LNX.4.44.0312030121130.1237-100000@xxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Wed, 3 Dec 2003 01:40:06 +0200 (EET)
Julian Anastasov <ja@xxxxxx> wrote:

> - ip_rt_frag_needed now provides interface index

I disagree with this.

There is no connection between the route (and thus output
device) we used to send a packet and the interface on which
an ICMP for that packet comes back upon.  Think assymetric
routes.

You changes mean that for routes with specific output interfaces,
we will ignore ICMPs for those routes that arrive on other interfaces
due to assymetric routing.

Why don't you create a seperate patch that just has the TOS masking
changes?  That's much less controversial and thus something I'm likely
to apply.

<Prev in Thread] Current Thread [Next in Thread>