| To: | "YOSHIFUJI Hideaki / ?$B5HF#1QL@?(B" <yoshfuji@xxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2.6]: IPv6: strcpy -> strlcpy |
| From: | Russell King <rmk+lkml@xxxxxxxxxxxxxxxx> |
| Date: | Thu, 27 Nov 2003 19:46:02 +0000 |
| Cc: | felipe_alfaro@xxxxxxxxxxxxx, davem@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <20031127.210953.116254624.yoshfuji@xxxxxxxxxxxxxx>; from yoshfuji@xxxxxxxxxxxxxx on Thu, Nov 27, 2003 at 09:09:53PM +0900 |
| Mail-followup-to: | "YOSHIFUJI Hideaki / ?$B5HF#1QL@?(B" <yoshfuji@xxxxxxxxxxxxxx>, felipe_alfaro@xxxxxxxxxxxxx, davem@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx |
| References: | <20031127.173320.19253188.yoshfuji@xxxxxxxxxxxxxx> <20031127025921.3fed8dd4.davem@xxxxxxxxxx> <1069934643.2393.0.camel@xxxxxxxxxxxxxxxxxxxxxxxx> <20031127.210953.116254624.yoshfuji@xxxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.2.5.1i |
On Thu, Nov 27, 2003 at 09:09:53PM +0900, YOSHIFUJI Hideaki / ?$B5HF#1QL@?(B wrote: > In article <1069934643.2393.0.camel@xxxxxxxxxxxxxxxxxxxxxxxx> (at Thu, 27 Nov > 2003 13:04:04 +0100), Felipe Alfaro Solana <felipe_alfaro@xxxxxxxxxxxxx> says: > > > On Thu, 2003-11-27 at 11:59, David S. Miller wrote: > > > > > I agree, using sizeof() is the less error prone way of > > > doing things like this. > > > > > > Felipe could you please rewrite your patch like this? > > > > Done! > > Thanks. Ok to me. I'm slightly cautious here, although I haven't read the patch yet. Did anyone consider whether any of these structures were copied to user space, and whether, as a result of this change, we're now copying uninitialised data to users? -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/ 2.6 Serial core |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: ipv4-mapped ipv4 connect() for UDP broken in test10, YOSHIFUJI Hideaki / 吉藤英明 |
|---|---|
| Next by Date: | Re: [PATCH 2.6]: IPv6: strcpy -> strlcpy, YOSHIFUJI Hideaki / 吉藤英明 |
| Previous by Thread: | Re: [PATCH 2.6]: IPv6: strcpy -> strlcpy, YOSHIFUJI Hideaki / 吉藤英明 |
| Next by Thread: | Re: [PATCH 2.6]: IPv6: strcpy -> strlcpy, YOSHIFUJI Hideaki / 吉藤英明 |
| Indexes: | [Date] [Thread] [Top] [All Lists] |