netdev
[Top] [All Lists]

Re: [TG3] Always load TSO firmware

To: "David S. Miller" <davem@xxxxxxxxxx>
Subject: Re: [TG3] Always load TSO firmware
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Thu, 20 Nov 2003 20:56:05 +1100
Cc: jgarzik@xxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20031117123836.2f8e70af.davem@xxxxxxxxxx>
References: <20031117093225.GA12420@xxxxxxxxxxxxxxxxxxx> <20031117123836.2f8e70af.davem@xxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.4i
On Mon, Nov 17, 2003 at 12:38:36PM -0800, David S. Miller wrote:
> 
> Whether we load the TSO firmware or not on 5705 determines how big
> an onboard buffer area we give to the chip for packet data.  It may
> be the case that we are miscalculating these values or not programming
> them into the chip correctly.

OK, I've cross-checked with the Broadcom drivers and the problem seems
to be specific to 5705 A1 which is the chipset in question.

The Broadcom drivers limit the number of rx descriptors to 63 while
tg3.c only limits it to 64.  It has been confirmed that lowering
the limit makes the problem go away.

Here is the patch.

Thanks,
-- 
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Attachment: q
Description: Text document

<Prev in Thread] Current Thread [Next in Thread>