netdev
[Top] [All Lists]

Re: [PATCH] 8139too NAPI for net-drivers-2.5-exp

To: Stephen Hemminger <shemminger@xxxxxxxx>
Subject: Re: [PATCH] 8139too NAPI for net-drivers-2.5-exp
From: Jeff Garzik <jgarzik@xxxxxxxxx>
Date: Wed, 19 Nov 2003 12:16:21 -0500
Cc: OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>, netdev@xxxxxxxxxxx, Jes Sorensen <jes@xxxxxxxxxxxxxxxxxx>
In-reply-to: <20031118161730.2690cb76.shemminger@xxxxxxxx>
References: <20031118161730.2690cb76.shemminger@xxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030703
Stephen Hemminger wrote:
Here is the 8139too version in net-drivers-2.5-exp modified for NAPI.
Also:
        64k receive ring - has to handle wrap for that case;
           the NoWrap flag does nothing if using this big ring.
        assert() -> BUG_ON()
        
To deal with the races with tx_timeout, put back in the rx_lock from earlier 
versions.


Applied with a "but"... This patch still contains some errors WRT 8139 hardware and the RX path. But I'm comfortable with nailing those problems down during public testing of net-drivers-2.5-exp.

Hirofumi, Stephen, and others, please test, particularly packet floods with (a) tiny packets and (b) huge packets. Ditto Jes, if you've still got hardware, and are interested in DoS fixes in 8139too.

        Jeff




<Prev in Thread] Current Thread [Next in Thread>