netdev
[Top] [All Lists]

Re: [PATCH] IPv6: Fix erratic behavior in rt6_dump_route()

To: Ville Nuorvala <vnuorval@xxxxxxxxxx>
Subject: Re: [PATCH] IPv6: Fix erratic behavior in rt6_dump_route()
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Mon, 17 Nov 2003 12:43:07 -0800
Cc: netdev@xxxxxxxxxxx
In-reply-to: <Pine.LNX.4.58.0311171155050.21177@xxxxxxxxxxxxxxx>
References: <Pine.LNX.4.58.0311171155050.21177@xxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Mon, 17 Nov 2003 12:11:52 +0200 (EET)
Ville Nuorvala <vnuorval@xxxxxxxxxx> wrote:

> Hi Dave!
> 
> I noticed some erratic behavior when doing "ip -6 r". I traced the problem
> to rt6_dump_route() where we typecast NLMSG_DATA() to a rtmsg without
> checking the size of the netlink message first. Seems like ip only passes
> a rtgenmsg to the kernel when it does a dump, so we end up reading pure
> garbage when we interpret it as a rtmsg. Please apply the patch!

Thanks a lot Ville, I will review your patch a bit more and
most likely apply it later today.

<Prev in Thread] Current Thread [Next in Thread>