netdev
[Top] [All Lists]

Re: Tigon3 5701 PCI-X recv performance problem

To: "David S. Miller" <davem@xxxxxxxxxx>
Subject: Re: Tigon3 5701 PCI-X recv performance problem
From: John Partridge <johnip@xxxxxxx>
Date: Tue, 11 Nov 2003 15:39:49 -0600
Cc: ak@xxxxxxx, netdev@xxxxxxxxxxx, jgarzik@xxxxxxxxx, jes@xxxxxxx, David Mosberger <davidm@xxxxxxxxxx>
In-reply-to: <20031111122403.2d7bcf28.davem@xxxxxxxxxx>
References: <3F844578.40306@xxxxxxx> <20031008101046.376abc3b.davem@xxxxxxxxxx> <3F8455BE.8080300@xxxxxxx> <20031008183742.GA24822@xxxxxxxxxxxxx> <20031008122223.1ba5ac79.davem@xxxxxxxxxx> <20031008202248.GA15611@xxxxxxxxxxxxxxxx> <3F8702FF.70500@xxxxxxx> <20031010192036.GA31727@xxxxxxxxxxxxx> <3F8802E6.5030601@xxxxxxx> <20031011131921.GC21763@xxxxxxxxxxxxx> <20031011105054.0e16a607.davem@xxxxxxxxxx> <3F8C290A.3010508@xxxxxxx> <20031014095323.71c8b9fe.davem@xxxxxxxxxx> <3FB03A56.7000709@xxxxxxx> <20031110182911.2c5a121b.davem@xxxxxxxxxx> <3FB140E2.1070007@xxxxxxx> <20031111122403.2d7bcf28.davem@xxxxxxxxxx>
Reply-to: johnip@xxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5) Gecko/20031022 Thunderbird/0.3
David S. Miller wrote:
Why are you depending upon MCKINLEY?  Don't all ia64 cpus
give traps for unaligned memory accesses?

That is what this CONFIG option tells the whole kernel.

OK, I made it ALL IA64, but I only know for sure about Itanium2's

--- linux/drivers/net/tg3.c     2003-11-10 18:28:10.000000000 -0600
+++ patch/drivers/net/tg3.c     2003-11-10 18:58:35.000000000 -0600
@@ -2257,7 +2257,11 @@

                len = ((desc->idx_len & RXD_LEN_MASK) >> RXD_LEN_SHIFT) - 4; /* 
omit crc */

-               if (len > RX_COPY_THRESHOLD) {
+               if (len > RX_COPY_THRESHOLD
+#if defined(CONFIG_UNALIGNED_EXPENSIVE)
+                        && tp->rx_offset == 2
+#endif
+               ) {
                        int skb_size;

                        skb_size = tg3_alloc_rx_skb(tp, opaque_key,
--- linux/arch/ia64/Kconfig     2003-10-25 13:44:46.000000000 -0500
+++ patch/arch/ia64/Kconfig     2003-11-11 15:37:58.000000000 -0600
@@ -468,6 +468,11 @@
          agent" (/sbin/hotplug) to load modules and set up software needed
          to use devices as you hotplug them.

+config CONFIG_UNALIGNED_EXPENSIVE
+       bool "Use kernel aligned buffers"
+       depends on IA64
+       default y
+
 source "drivers/pci/hotplug/Kconfig"

 source "drivers/pcmcia/Kconfig"

--
John Partridge

Silicon Graphics Inc
Tel:  651-683-3428
Vnet: 233-3428
E-Mail: johnip@xxxxxxx


<Prev in Thread] Current Thread [Next in Thread>