| To: | davem@xxxxxxxxxx (David S. Miller) |
|---|---|
| Subject: | Re: [2.4/2.6 PATCHES] Change some ip_fragment checks to help IPVS |
| From: | kuznet@xxxxxxxxxxxxx |
| Date: | Tue, 14 Oct 2003 16:03:32 +0400 (MSD) |
| Cc: | ja@xxxxxx, wensong@xxxxxxxxxxxx, netdev@xxxxxxxxxxx, kuznet@xxxxxxxxxxxxx |
| In-reply-to: | <20031011120228.74914c91.davem@xxxxxxxxxx> from "David S. Miller" at οΛΤ 11, 2003 12:02:28 |
| Sender: | netdev-bounce@xxxxxxxxxxx |
Hello! > On Sat, 11 Oct 2003 20:18:33 +0300 (EEST) > Julian Anastasov <ja@xxxxxx> wrote: > > > /* Correct socket ownership. */ > > - if (frag->sk == NULL) > > + if (frag->sk == NULL && skb->sk) > > goto slow_path; > > Alexey I think this piece of Julian's patch is OK and this is > the test you meant to make in the first place. Yes. The test was to eliminate the pathological cases, but the test is really valid only when skb is generated by ip_append_*. If skb as whole is now owned, it is also perfect case. > Right? Perfectly correct. Alexey |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | 3c900 Vortex Linux kernel driver documentation, Karel Kulhavý |
|---|---|
| Next by Date: | [PATCH] (linux-2.6.0-test7) fix missing connections in /proc/net/tcp ("netstat -n -t -a"), Tim Shepard |
| Previous by Thread: | Re: [2.4/2.6 PATCHES] Change some ip_fragment checks to help IPVS, David S. Miller |
| Next by Thread: | Re: [2.4/2.6 PATCHES] Change some ip_fragment checks to help IPVS, Julian Anastasov |
| Indexes: | [Date] [Thread] [Top] [All Lists] |