netdev
[Top] [All Lists]

Re: [PATCH] Handle shared SKBs in VLAN receive code

To: Ben Greear <greearb@xxxxxxxxxxxxxxx>
Subject: Re: [PATCH] Handle shared SKBs in VLAN receive code
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Sat, 11 Oct 2003 12:03:39 -0700
Cc: tommy.christensen@xxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <3F885418.3090407@xxxxxxxxxxxxxxx>
References: <3F87430D.2040000@xxxxxxxxx> <3F87464B.1020908@xxxxxxxxxxxxxxx> <3F874A30.6010700@xxxxxxxxx> <3F885418.3090407@xxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Sat, 11 Oct 2003 12:03:52 -0700
Ben Greear <greearb@xxxxxxxxxxxxxxx> wrote:

> Maybe we should have a method called:  
> skb_get_me_an_skb_that_I_can_modify(skb);
> 
> Then the subtle differences between sharing, cloning, etc can be handled
> by the skb code internally...

We can't create this routine, because it depends upon context.

The current code is correct and handles shared SKBs properly,
so I don't think it's worth playing around with this much more.

<Prev in Thread] Current Thread [Next in Thread>