netdev
[Top] [All Lists]

Re: [PATCH] Fix 64bit bugs in dscc44.c II

To: "David S. Miller" <davem@xxxxxxxxxx>
Subject: Re: [PATCH] Fix 64bit bugs in dscc44.c II
From: Andi Kleen <ak@xxxxxxx>
Date: Wed, 8 Oct 2003 18:33:45 +0200
Cc: Andi Kleen <ak@xxxxxxx>, ak@xxxxxx, ncorbic@xxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20031008091050.11b2acb7.davem@xxxxxxxxxx>
References: <20031007175953.GA1802@averell> <20031008084205.5c81faac.davem@xxxxxxxxxx> <20031008155548.GB16937@xxxxxxxxxxxxx> <20031008090132.2b58c067.davem@xxxxxxxxxx> <20031008160859.GD16937@xxxxxxxxxxxxx> <20031008161149.GA8134@xxxxxxxxxxxxx> <20031008091050.11b2acb7.davem@xxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Wed, Oct 08, 2003 at 09:10:50AM -0700, David S. Miller wrote:
> > BTW my change fixed the warning.
> 
> I know, but it added a new one.
> 
> > It's somewhat ugly to store pointers in unsigned long I agree,
> 
> I have _NO_ problem with this, all I'm asking you to do is:
> 
> -     foo = ioremap_nocache(...);
> +     foo = (unsigned long) ioremap_nocache(...);

Just do that then when you apply the patch. Would have been faster
than to write all these emails ;-)

-Andi

<Prev in Thread] Current Thread [Next in Thread>