netdev
[Top] [All Lists]

Re: [PATCH] Fix 64bit bugs in dscc44.c II

To: Andi Kleen <ak@xxxxxxx>
Subject: Re: [PATCH] Fix 64bit bugs in dscc44.c II
From: Andi Kleen <ak@xxxxxxx>
Date: Wed, 8 Oct 2003 18:11:49 +0200
Cc: "David S. Miller" <davem@xxxxxxxxxx>, ak@xxxxxx, ncorbic@xxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20031008160859.GD16937@xxxxxxxxxxxxx>
References: <20031007175953.GA1802@averell> <20031008084205.5c81faac.davem@xxxxxxxxxx> <20031008155548.GB16937@xxxxxxxxxxxxx> <20031008090132.2b58c067.davem@xxxxxxxxxx> <20031008160859.GD16937@xxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
> I don't particularly care about the warning, just that it will
> obviously crash on a 64bit box when loaded. My change was the simplest 
> possible fix for that. I have no plans to rewrite this driver
> or something.

BTW my change fixed the warning.

It's somewhat ugly to store pointers in unsigned long I agree,
but it's hard to blame the driver author when this cruft is even
enshrined in fundamental interfaces (__get_free_pages/__free_pages) 

-Andi

<Prev in Thread] Current Thread [Next in Thread>