Re: [PATCH] Fix 64bit bugs in dscc44.c II

To:	Andi Kleen <ak@xxxxxxx>
Subject:	Re: [PATCH] Fix 64bit bugs in dscc44.c II
From:	"David S. Miller" <davem@xxxxxxxxxx>
Date:	Wed, 8 Oct 2003 09:10:50 -0700
Cc:	ak@xxxxxxx, ak@xxxxxx, ncorbic@xxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to:	<20031008161149.GA8134@xxxxxxxxxxxxx>
References:	<20031007175953.GA1802@averell> <20031008084205.5c81faac.davem@xxxxxxxxxx> <20031008155548.GB16937@xxxxxxxxxxxxx> <20031008090132.2b58c067.davem@xxxxxxxxxx> <20031008160859.GD16937@xxxxxxxxxxxxx> <20031008161149.GA8134@xxxxxxxxxxxxx>
Sender:	netdev-bounce@xxxxxxxxxxx

> BTW my change fixed the warning.

I know, but it added a new one.

> It's somewhat ugly to store pointers in unsigned long I agree,

I have _NO_ problem with this, all I'm asking you to do is:

-       foo = ioremap_nocache(...);
+       foo = (unsigned long) ioremap_nocache(...);

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] Fix 64bit bugs in dscc44.c, Andi Kleen Re: [PATCH] Fix 64bit bugs in dscc4.c, Francois Romieu Re: [PATCH] Fix 64bit bugs in dscc44.c, David S. Miller Re: [PATCH] Fix 64bit bugs in dscc44.c, Andi Kleen Re: [PATCH] Fix 64bit bugs in dscc44.c, David S. Miller Re: [PATCH] Fix 64bit bugs in dscc44.c, Andi Kleen Re: [PATCH] Fix 64bit bugs in dscc44.c II, Andi Kleen Re: [PATCH] Fix 64bit bugs in dscc44.c II, David S. Miller <= Re: [PATCH] Fix 64bit bugs in dscc44.c II, Andi Kleen Re: [PATCH] Fix 64bit bugs in dscc44.c II, David S. Miller Re: [PATCH] Fix 64bit bugs in dscc44.c II, Andi Kleen Re: [PATCH] Fix 64bit bugs in dscc44.c II, David S. Miller

Previous by Date:	Re: [PATCH] Fix 64bit bugs in dscc44.c, David S. Miller
Next by Date:	Re: [PATCH] Fix 64bit bugs in dscc44.c, Andi Kleen
Previous by Thread:	Re: [PATCH] Fix 64bit bugs in dscc44.c II, Andi Kleen
Next by Thread:	Re: [PATCH] Fix 64bit bugs in dscc44.c II, Andi Kleen
Indexes:	[Date] [Thread] [Top] [All Lists]