netdev
[Top] [All Lists]

Re: comment on [NET]: Delete support for old-style protocols, no longer

To: David S Miller <davem@xxxxxxxxxx>
Subject: Re: comment on [NET]: Delete support for old-style protocols, no longer necessary.
From: Joe Perches <joe@xxxxxxxxxxx>
Date: Tue, 07 Oct 2003 16:33:40 -0700
Cc: davem@xxxxxxxxxxxxxx, linux-net@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20031007115244.14a887ed.davem@xxxxxxxxxx>
References: <1065551829.2340.9.camel@xxxxxxxxxxxxxxxxxxxxx> <20031007115244.14a887ed.davem@xxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Tue, 2003-10-07 at 11:52, David S. Miller wrote:
> On Tue, 07 Oct 2003 11:37:09 -0700
> Joe Perches <joe@xxxxxxxxxxx> wrote:
> 
> > -       void                    *af_packet_priv;
> > +       struct sock             *sk;        /* appropriate comment: socket 
> > copy? */
> 
> AF_PACKET is the only user of this private field, and
> I want people to be aware of this and not try to use it
> for other stuff.
> 
> Nobody else can use it for something different, the code
> in net/core/dev.c does specific things when it's non-NULL
> knowing that this non-NULL value means that it's an
> AF_PACKET packet_type being passed to it.
> 
> So we won't make your suggested change.

Even so, why not call it a struct sock*?
It is after all and is used as one.



<Prev in Thread] Current Thread [Next in Thread>