netdev
[Top] [All Lists]

Re: [Bridge] Re: [PATCH/RFC] Let {ip, arp}tables "see" bridged VLAN tagg

To: Ben Greear <greearb@xxxxxxxxxxxxxxx>
Subject: Re: [Bridge] Re: [PATCH/RFC] Let {ip, arp}tables "see" bridged VLAN tagged {I, AR}P packets
From: Bart De Schuymer <bdschuym@xxxxxxxxxx>
Date: Mon, 6 Oct 2003 22:58:27 +0200
Cc: netdev@xxxxxxxxxxx, vlan@xxxxxxxxxxx, bridge <bridge@xxxxxxxx>, Stephen Hemminger <shemminger@xxxxxxxx>
In-reply-to: <3F81CF75.5050802@xxxxxxxxxxxxxxx>
References: <200310062204.07230.bdschuym@xxxxxxxxxx> <3F81CF75.5050802@xxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: KMail/1.5
On Monday 06 October 2003 22:24, Ben Greear wrote:
> Bart De Schuymer wrote:
> > - add some code in vlan_dev.c::vlan_dev_hard_start_xmit():
> > skb->protocol = __constant_htons(ETH_P_8021Q);
> > skb->mac.raw -= VLAN_HLEN;
> > skb->nh.raw -= VLAN_HLEN;
>
> I wonder if this is what was messing up the tcpdump packet capture
> as well?

A wrong Ethernet header pointer should probably do the trick.

> It would be fine with me if you un-conditionally exported the
> vlan hard-start-xmit pointer, but I don't feel strongly either way.

Me neither. I just let Dave decide in those cases :-)

cheers,
Bart


<Prev in Thread] Current Thread [Next in Thread>