| To: | Jeff Garzik <jgarzik@xxxxxxxxx> |
|---|---|
| Subject: | Re: Fw: [BUG/PATCH] CONFIG_NET_HW_FLOWCONTROL and SMP |
| From: | Robert Olsson <Robert.Olsson@xxxxxxxxxxx> |
| Date: | Fri, 3 Oct 2003 16:10:33 +0200 |
| Cc: | Robert Olsson <Robert.Olsson@xxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxx>, netdev@xxxxxxxxxxx, dfages@xxxxxxxxxx |
| In-reply-to: | <3F7C64BC.7030701@xxxxxxxxx> |
| References: | <20030929123734.5bd97a47.akpm@xxxxxxxx> <16248.41796.797321.700866@xxxxxxxxxxxx> <3F78A691.1040406@xxxxxxxxx> <16252.17618.866515.952549@xxxxxxxxxxxx> <3F7C64BC.7030701@xxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
Jeff Garzik writes:
>
> Looks great to me. I'll give it some testing here, and 99% likely will
> apply it.
>
> Andrew, would you be willing to merge this into -mm for some
> simultaneous netwide testing?
Fine!
Here is a additional patch to active disable poll so we don't have to wait in
dev_close() for traffic to disappear.
Cheers.
--ro
--- drivers/net/tulip/interrupt.c.03103 2001-11-03 18:52:54.000000000 +0100
+++ drivers/net/tulip/interrupt.c 2003-10-03 13:21:46.000000000 +0200
@@ -116,6 +116,8 @@
tp->stats_poll_starts++;
#endif
+ if(!netif_running(dev)) goto done;
+
if (rx_work_limit > dev->quota)
rx_work_limit = dev->quota;
@@ -241,7 +243,7 @@
* finally: amount of IO did not increase at all. */
} while ((inl(dev->base_addr + CSR5) & RxIntr));
-/* done: */
+done:
#ifdef USE_MITIGATION
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [RFC] add rtnl semaphore to linux-atm, David S. Miller |
|---|---|
| Next by Date: | Re: tunnel xmit and h.raw, David S. Miller |
| Previous by Thread: | Re: Fw: [BUG/PATCH] CONFIG_NET_HW_FLOWCONTROL and SMP, Andrew Morton |
| Next by Thread: | mod_timer improvement, Steve Modica |
| Indexes: | [Date] [Thread] [Top] [All Lists] |