| To: | Mitchell Blank Jr <mitch@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [RFC] add rtnl semaphore to linux-atm |
| From: | "David S. Miller" <davem@xxxxxxxxxx> |
| Date: | Fri, 3 Oct 2003 06:58:24 -0700 |
| Cc: | chas3@xxxxxxxxxxxxxxxxxxxxx, chas@xxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <20031003022615.GA42593@xxxxxxxxxxxxxx> |
| References: | <200310011134.h91BYPkT003172@xxxxxxxxxxxxxxxxxxxxxxx> <20031001054226.126cea7b.davem@xxxxxxxxxx> <20031003022615.GA42593@xxxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Thu, 2 Oct 2003 19:26:15 -0700 Mitchell Blank Jr <mitch@xxxxxxxxxx> wrote: > My personal recommendations: > * There should be a per-atm-device semaphore held across calls into the > driver's ->open, ->close, ->change_qos and maybe a couple other things > to serialize those operations (for the sake of keeping the drivers > sane - there's no reason there should be multiple operations pending) Ok, but what Chas is trying to do is move the ATM device stuff over to a model that makes use of the existing network device infrastructure for solving these kinds of problems. Part of that is using the rtnl semaphore etc. I would rather Chas use the rtnl semaphore for synchronization than to ultra-optimize this code by using the rwlock as I had suggested to him. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] (1/11) Irda dongle module owner support, David S. Miller |
|---|---|
| Next by Date: | Re: Fw: [BUG/PATCH] CONFIG_NET_HW_FLOWCONTROL and SMP, Robert Olsson |
| Previous by Thread: | Re: [RFC] add rtnl semaphore to linux-atm, Mitchell Blank Jr |
| Next by Thread: | Re: [RFC] add rtnl semaphore to linux-atm, Mitchell Blank Jr |
| Indexes: | [Date] [Thread] [Top] [All Lists] |