netdev
[Top] [All Lists]

Re: [Bonding-announce] [PATCH SET][bonding] cleanup

To: Shmulik Hen <shmulik.hen@xxxxxxxxx>
Subject: Re: [Bonding-announce] [PATCH SET][bonding] cleanup
From: "Chad N. Tindel" <chad@xxxxxxxxxx>
Date: Thu, 25 Sep 2003 12:47:19 -0400
Cc: bonding-devel@xxxxxxxxxxxxxxxxxxxxx, bonding-announce@xxxxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-net@xxxxxxxxxxxxxxx, Jeff Garzik <jgarzik@xxxxxxxxx>, Jay Vosburgh <fubar@xxxxxxxxxx>, "Noam, Amir" <amir.noam@xxxxxxxxx>, "Mendelson, Tsippy" <tsippy.mendelson@xxxxxxxxx>, "Noam, Marom" <noam.marom@xxxxxxxxx>
In-reply-to: <200309251549.59177.shmulik.hen@xxxxxxxxx>
Mail-followup-to: Shmulik Hen <shmulik.hen@xxxxxxxxx>, bonding-devel@xxxxxxxxxxxxxxxxxxxxx, bonding-announce@xxxxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-net@xxxxxxxxxxxxxxx, Jeff Garzik <jgarzik@xxxxxxxxx>, Jay Vosburgh <fubar@xxxxxxxxxx>, "Noam, Amir" <amir.noam@xxxxxxxxx>, "Mendelson, Tsippy" <tsippy.mendelson@xxxxxxxxx>, "Noam, Marom" <noam.marom@xxxxxxxxx>
References: <200309251549.59177.shmulik.hen@xxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4i
> patch set can be downloaded from:
> http://osdn.dl.sourceforge.net/sourceforge/bonding/bonding-cleanup-2.4.23-pre5.tar.bz2
> 
> This will update the following files:
> 
>         Documentation/networking/bonding.txt
>         Documentation/networking/ifenslave.c
>         drivers/net/bonding/bond_3ad.c
>         drivers/net/bonding/bond_alb.c
>         drivers/net/bonding/bond_alb.h
>         drivers/net/bonding/bonding.h
>         drivers/net/bonding/bond_main.c
>         include/linux/if_bonding.h
> 
> Description:
> patch 1 - ifenslave lite - No more IP settings to slaves, unified 
>           printing format, code re-org and broken to more functions.
> patch 2 - convert all debug prints to use the dprintk macro and 
>           consolidate format of all prints (e.g. "bonding: Error: 
>           ...").
> patch 3 - death of typedef. eliminate bonding_t/slave_t types and 
>           consolidate casting.
> patch 4 - remove dead code, old compatibility stuff and redundant 
>           checks.

I'm a bit concerned about doing some of this stuff in the 2.4 series.  That
compatibility stuff is there for a reason, and was set to be removed in
2.6.  Perhaps we shouldn't be doing stuff this drastic until 2.6 because of
the risk of breaking users.  

Chad

<Prev in Thread] Current Thread [Next in Thread>